Modify codes in order to compatible with Swift 4.2. In addition, Support macOS Dark mode.#31
Open
es-kumagai wants to merge 18 commits into
Open
Modify codes in order to compatible with Swift 4.2. In addition, Support macOS Dark mode.#31es-kumagai wants to merge 18 commits into
es-kumagai wants to merge 18 commits into
Conversation
… is forked and modified in order to corresponding to swift 4.2. This modified pod is requested as PR steve228uk/SRTabBarController#13 . If this PR accepted and published the pod in public, this commit is no longer needed. We can revert this commit.
…e to appropriate place (draw → awakeFromNib)
… to recover is prepared during running QBlocker.
…Non-NS Prefixed types.
Because NSLog output message to device's console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes many changes but modify carefully to keep original behavior. Some codes not only replacing but also refactor to fit Swift 4.2. Modify constraints of auto layout and view hierarchy in storyboard too.
There is an important note
To corresponding to Swift 4.2, TEMPORARILY, Replace a pod named
SRTabBarControlleris downloaded from repository which placed https://github.com/es-kumagai/SRTabBarController. This repository is a fork and modified codes to support Swift 4.2.This modification is already sent as PR ( steve228uk/SRTabBarController#13 )
If merge the PR, the commit 68b408b is no longer needed, can revert it.